scheduler: fix duplicate slot #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Nov 7, 2022
| @@ -47,7 +47,7 @@ func NewSyncCommMember(eth2Cl eth2wrap.Client, epoch eth2p0.Epoch, signFunc Sign | |||
| dutiesOK: make(chan struct{}), | |||
| selections: make(map[eth2p0.Slot]syncSelections), | |||
| selectionsOK: make(map[eth2p0.Slot]chan struct{}), | |||
| blockRoot: make(map[eth2p0.Slot]*eth2p0.Root), | |||
There was a problem hiding this comment.
changing this it non-pointer since basic eth2 types aren't pointers and this causes a panic when duties time out.
Codecov ReportBase: 53.19% // Head: 53.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1392 +/- ##
==========================================
- Coverage 53.19% 53.13% -0.07%
==========================================
Files 145 145
Lines 18226 18226
==========================================
- Hits 9696 9684 -12
- Misses 7201 7207 +6
- Partials 1329 1335 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues due to sporadic duplicate slot scheduling.
category: bug
ticket: #1389