tbls: revert changes to TSS struct #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Feb 28, 2022
| Threshold int | ||
| // Threshold returns the minimum number of partial signatures required to aggregate the threshold signature. | ||
| func (t TSS) Threshold() int { | ||
| return len(t.verifier.Commitments) | ||
| } | ||
|
|
||
| func NewTSS(verifier *share.FeldmanVerifier, numShares int) (TSS, error) { |
There was a problem hiding this comment.
I think it is good to still calculate the public key on construction:
- Then we fail fast if we cannot calculate it, instead of later.
- Reduces error handling in general.
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage ? 54.55%
=======================================
Files ? 30
Lines ? 1976
Branches ? 0
=======================================
Hits ? 1078
Misses ? 792
Partials ? 106 Continue to review full report at Codecov.
|
corverroos
commented
Feb 28, 2022
Comment on lines
40
to
+46
| type TSS struct { | ||
| Verifier *share.FeldmanVerifier | ||
| NumShares int | ||
| verifier *share.FeldmanVerifier | ||
| numShares int | ||
|
|
||
| // PublicKey and Threshold are inferred from verifier commitments in NewTSS. | ||
| // publicKey inferred from verifier commitments in NewTSS. | ||
| publicKey *bls_sig.PublicKey | ||
| } |
There was a problem hiding this comment.
refactoring to private fields, with getter methods. To make it explicit that you should use NewTSS for constructing.
Adds unit tests to the scheduler package. Also adds some helper test utils: - app/golden: for golden file testing - beaconmock: beacon client mock category: testing ticket: #145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #136 by decoupling the dependency on TSS struct from scheduler, rather provide public keys directly.
category: refactor
ticket: #145