Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/qbft: include round when deduping #1505

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Since some messages are justified, justified rules can be triggered for a future (or a previous) round at any point. So include round when deduping.

category: bug
ticket: #1493

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 54.34% // Head: 54.25% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (10cbf41) compared to base (0c59023).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   54.34%   54.25%   -0.09%     
==========================================
  Files         149      149              
  Lines       19019    19016       -3     
==========================================
- Hits        10335    10317      -18     
- Misses       7285     7296      +11     
- Partials     1399     1403       +4     
Impacted Files Coverage Δ
core/qbft/qbft.go 83.82% <100.00%> (+1.36%) ⬆️
app/vmock.go 71.50% <0.00%> (-4.15%) ⬇️
app/app.go 63.60% <0.00%> (-2.26%) ⬇️
core/parsigdb/memory.go 48.09% <0.00%> (-1.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 6, 2022
@obol-bulldozer obol-bulldozer bot merged commit f47d74c into main Dec 6, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/qbftdedup branch December 6, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants