log/loki: lazy loading of cluster labels #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.34% // Head: 54.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
==========================================
- Coverage 54.34% 54.20% -0.14%
==========================================
Files 149 149
Lines 19019 19063 +44
==========================================
- Hits 10335 10333 -2
- Misses 7285 7326 +41
- Partials 1399 1404 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Dec 6, 2022
| @@ -33,7 +33,11 @@ import ( | |||
| ) | |||
|
|
|||
| func TestLoki(t *testing.T) { | |||
There was a problem hiding this comment.
suggest: add golden json to this test
There was a problem hiding this comment.
little tricky to do this actually
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lazy loaded cluster labels when pushing logs to loki so we can filter and query by node/cluster/network.
category: feature
ticket: #1509