Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/promrated: implement rated fetching and reporting #1569

Merged
merged 7 commits into from
Dec 16, 2022

Conversation

LukeHackett12
Copy link
Contributor

Adds fetching of rated effectiveness and making these metrics available to prometheus.

category: misc
ticket: #1540

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 54.16% // Head: 53.96% // Decreases project coverage by -0.19% ⚠️

Coverage data is based on head (46232b0) compared to base (708c345).
Patch coverage: 40.81% of modified lines in pull request are covered.

❗ Current head 46232b0 differs from pull request most recent head bf47a5d. Consider uploading reports for the commit bf47a5d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
- Coverage   54.16%   53.96%   -0.20%     
==========================================
  Files         156      157       +1     
  Lines       19626    19717      +91     
==========================================
+ Hits        10630    10641      +11     
- Misses       7558     7630      +72     
- Partials     1438     1446       +8     
Impacted Files Coverage Δ
testutil/promrated/prometheus.go 42.02% <0.00%> (ø)
testutil/promrated/promrated.go 0.00% <0.00%> (ø)
testutil/promrated/rated.go 57.14% <57.14%> (ø)
core/qbft/qbft.go 73.73% <0.00%> (-10.09%) ⬇️
app/monitoringapi.go 81.45% <0.00%> (+0.15%) ⬆️
cmd/bootnode/p2p.go 38.31% <0.00%> (+0.24%) ⬆️
app/app.go 64.32% <0.00%> (+0.70%) ⬆️
core/priority/prioritiser.go 61.69% <0.00%> (+2.82%) ⬆️
app/vmock.go 77.72% <0.00%> (+3.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LukeHackett12 LukeHackett12 marked this pull request as ready for review December 16, 2022 09:36
testutil/promrated/metrics.go Outdated Show resolved Hide resolved
testutil/promrated/promrated.go Outdated Show resolved Hide resolved
testutil/promrated/promrated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/metrics.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
testutil/promrated/rated.go Outdated Show resolved Hide resolved
@LukeHackett12 LukeHackett12 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Dec 16, 2022
@obol-bulldozer obol-bulldozer bot merged commit 4a524f4 into main Dec 16, 2022
@obol-bulldozer obol-bulldozer bot deleted the luke/promrated-rated branch December 16, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants