core/validatorapi: improve error #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 53.84% // Head: 54.25% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1586 +/- ##
==========================================
+ Coverage 53.84% 54.25% +0.41%
==========================================
Files 157 157
Lines 19880 19934 +54
==========================================
+ Hits 10705 10816 +111
+ Misses 7729 7664 -65
- Partials 1446 1454 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
reviewed
Jan 5, 2023
core/validatorapi/validatorapi.go
Outdated
| @@ -56,7 +56,7 @@ func NewComponentInsecure(_ *testing.T, eth2Cl eth2wrap.Client, shareIdx int) (* | |||
|
|
|||
| // NewComponent returns a new instance of the validator API core workflow component. | |||
| func NewComponent(eth2Cl eth2wrap.Client, pubShareByKey map[*bls_sig.PublicKey]*bls_sig.PublicKey, | |||
There was a problem hiding this comment.
you are passing in the same data pubShareByKey twice but in different formats
There was a problem hiding this comment.
That's right. Maybe we can replace pubShareByKey with allPubSharesByKey? Since we can calculate relevant pubkey mappings from the latter
corverroos
reviewed
Jan 5, 2023
xenowits
force-pushed
the
xenowits/mismatch-keyshares
branch
from
babb028
to
b69ae73
Compare
corverroos
approved these changes
Jan 6, 2023
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves error message when when VC key share index doesn't match charon index.
category: feature
ticket: #947