core/scheduler: delete expired duties #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.14% // Head: 54.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
- Coverage 54.14% 54.14% -0.01%
==========================================
Files 157 157
Lines 19916 19931 +15
==========================================
+ Hits 10784 10791 +7
- Misses 7678 7682 +4
- Partials 1454 1458 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dB2510
approved these changes
Jan 6, 2023
corverroos
added
the
merge when ready
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
Fixes issue introduced by #1596 that trimmed data after 5 slots which caused inclusion delay calculation to stop working (it requires duties of 32 ago). Instead just delete duties after 3 epochs (avoid races and off-by-one issues of 2 epochs). category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete expired duties from scheduler.
category: feature
ticket: #1584