cmd/relay: serve multiaddrs from http address #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.37% // Head: 54.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
==========================================
- Coverage 54.37% 54.14% -0.24%
==========================================
Files 158 158
Lines 20383 20391 +8
==========================================
- Hits 11083 11040 -43
- Misses 7812 7863 +51
Partials 1488 1488
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
reviewed
Jan 18, 2023
| @@ -41,7 +41,7 @@ import ( | |||
| ) | |||
|
|
|||
| // NewTCPNode returns a started tcp-based libp2p host. | |||
| func NewTCPNode(ctx context.Context, cfg Config, key *ecdsa.PrivateKey, connGater ConnGater, opts ...libp2p.Option, | |||
| func NewTCPNode(ctx context.Context, cfg Config, key *ecdsa.PrivateKey, connGater ConnGater, advertise bool, opts ...libp2p.Option, | |||
There was a problem hiding this comment.
what is the advertise parameter used for? maybe add to the godoc of this function
There was a problem hiding this comment.
it will be removed soon
xenowits
approved these changes
Jan 18, 2023
corverroos
added
the
merge when ready
dB2510
reviewed
Jan 18, 2023
| @@ -72,3 +78,60 @@ func TestRunBootnodeAutoP2P(t *testing.T) { | |||
| testutil.SkipIfBindErr(t, err) | |||
| require.NoError(t, err) | |||
| } | |||
|
|
|||
| func TestServeMultiAddrs(t *testing.T) { | |||
There was a problem hiding this comment.
can we have testutil.RequireGoldenJSON(...) for this test for json response of http call?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay serves multiaddrs from http-address server.
category: feature
ticket: #1632