Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: refactor create cluster to use keymanager package #1662

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

xenowits
Copy link
Contributor

Refactors create cluster to use the new keymanager package.

category: refactor
ticket: #1503

@xenowits xenowits self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 54.45% // Head: 54.63% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (47a5f81) compared to base (714e7f7).
Patch coverage: 72.72% of modified lines in pull request are covered.

❗ Current head 47a5f81 differs from pull request most recent head fbcf0da. Consider uploading reports for the commit fbcf0da to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
+ Coverage   54.45%   54.63%   +0.18%     
==========================================
  Files         157      157              
  Lines       20024    20028       +4     
==========================================
+ Hits        10904    10943      +39     
+ Misses       7667     7636      -31     
+ Partials     1453     1449       -4     
Impacted Files Coverage Δ
eth2util/keystore/keystore.go 48.64% <ø> (+5.44%) ⬆️
cmd/createcluster.go 53.15% <72.72%> (+<0.01%) ⬆️
core/consensus/transport.go 64.58% <0.00%> (-0.70%) ⬇️
app/vmock.go 74.09% <0.00%> (ø)
core/qbft/qbft.go 83.40% <0.00%> (ø)
core/priority/prioritiser.go 61.69% <0.00%> (+2.82%) ⬆️
eth2util/enr/enr.go 72.51% <0.00%> (+16.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits force-pushed the xenowits/refactor-create-cluster branch from 642f780 to 22ea095 Compare January 19, 2023 15:54
cmd/createcluster.go Outdated Show resolved Hide resolved
@xenowits xenowits added merge when ready Indicates bulldozer bot may merge when all checks pass and removed merge when ready Indicates bulldozer bot may merge when all checks pass labels Jan 23, 2023
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 23, 2023
@obol-bulldozer obol-bulldozer bot merged commit 3be6033 into main Jan 23, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/refactor-create-cluster branch January 23, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants