Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: create draft 1.5 definition #1674

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Conversation

LukeHackett12
Copy link
Contributor

@LukeHackett12 LukeHackett12 commented Jan 24, 2023

Adds a new 1.5 cluster definition version with individual fee recipients and withdrawal addresses per validator. This PR is only to add these fields, not use them for now.

category: feature
ticket: #1645

@LukeHackett12 LukeHackett12 changed the title Luke/cluster def 1x5 cluster: create draft 1.5 definition Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 54.55% // Head: 54.48% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (810a560) compared to base (e412352).
Patch coverage: 74.32% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   54.55%   54.48%   -0.07%     
==========================================
  Files         158      158              
  Lines       20233    20484     +251     
==========================================
+ Hits        11038    11161     +123     
- Misses       7735     7837     +102     
- Partials     1460     1486      +26     
Impacted Files Coverage Δ
cmd/createcluster.go 52.65% <30.00%> (-0.50%) ⬇️
dkg/dkg.go 53.86% <33.33%> (-0.26%) ⬇️
app/app.go 63.78% <57.14%> (-0.29%) ⬇️
cluster/ssz.go 75.06% <68.46%> (-4.06%) ⬇️
cluster/definition.go 68.19% <82.75%> (+2.35%) ⬆️
cluster/lock.go 58.10% <100.00%> (ø)
cluster/version.go 100.00% <100.00%> (ø)
core/qbft/qbft.go 73.73% <0.00%> (-10.09%) ⬇️
app/vmock.go 73.05% <0.00%> (-1.04%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cluster/definition.go Outdated Show resolved Hide resolved
cluster/definition.go Outdated Show resolved Hide resolved
cluster/lock.go Outdated Show resolved Hide resolved
cluster/version.go Outdated Show resolved Hide resolved
@LukeHackett12 LukeHackett12 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 24, 2023
@obol-bulldozer obol-bulldozer bot merged commit a3e5bdf into main Jan 24, 2023
@obol-bulldozer obol-bulldozer bot deleted the luke/cluster-def-1x5 branch January 24, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants