Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth2wrap: fix node peer count #1681

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Conversation

xenowits
Copy link
Contributor

Fixes bug in NodePeerCount method.

category: bug
ticket: #1603

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 54.58% // Head: 54.62% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (55953e2) compared to base (e95d9b8).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 55953e2 differs from pull request most recent head b9bacf6. Consider uploading reports for the commit b9bacf6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1681      +/-   ##
==========================================
+ Coverage   54.58%   54.62%   +0.03%     
==========================================
  Files         158      158              
  Lines       20545    20545              
==========================================
+ Hits        11215    11222       +7     
+ Misses       7842     7836       -6     
+ Partials     1488     1487       -1     
Impacted Files Coverage Δ
app/eth2wrap/httpwrap.go 22.76% <0.00%> (ø)
core/qbft/qbft.go 83.40% <0.00%> (ø)
core/scheduler/scheduler.go 74.25% <0.00%> (+0.45%) ⬆️
core/leadercast/transport.go 76.33% <0.00%> (+1.18%) ⬆️
app/vmock.go 75.64% <0.00%> (+1.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

app/eth2wrap/httpwrap.go Fixed Show fixed Hide fixed
app/monitoringapi.go Outdated Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 25, 2023
@obol-bulldozer obol-bulldozer bot merged commit 29b8806 into main Jan 25, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/fix-node-peer-count branch January 25, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants