tbls: library for BLS12-381 abstraction #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adds an example implementation of the BLS abstraction for Herumi's BLS library. This code is not finished (missing testing, and many Godoc comments), and it is pushed as a request for comment from the team.
…cts. The `taketwo` package is a placeholder, once we settle on an interface it will be all merged under `tbls`.
use `var x type` form
Just a thin wrapper over []byte, to favorite type safety.
Needed because Kryptology API requires it.
Missing ThresholdAggregate, Verify and Sign, plus tests.
Since we're trying to abstract library details, it makes sense to have a common set of tests, and something in place that allows us to run it by switching the underlying implementation.
Shared test suite looks alright.
This taketwo.Implementation takes a set of taketwo.Implementation's, and whenever one of the interface's method is called it takes one randomly. This is useful for testing, since it can tell us whether a set of taketwo.Implementation's are compatible among themselves.
Helps with randomization/compatibility testing.
Once we migrate away from the original bls abstraction implementation, v2 package content will move to the root tbls package.
Helps with type safety.
|
Fixing linting issues as we speak. |
Codecov ReportBase: 54.31% // Head: 54.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
+ Coverage 54.31% 54.54% +0.23%
==========================================
Files 158 161 +3
Lines 20339 20652 +313
==========================================
+ Hits 11047 11265 +218
- Misses 7807 7892 +85
- Partials 1485 1495 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gsora
changed the title
corverroos
approved these changes
Jan 26, 2023
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a subpackage in
tblscalledv2, which is a new abstraction for BLS12-381 cryptography.It contains two concrete implementations — one using Herumi and another based on Kryptology, added for backwards compatibility while we work out the migration.
A complete test suite is provided, alongside a fuzzing target to test cross-compatibility between implementation.
Preliminary tests show substantial performance improvements.
category: refactor
ticket: #1658