Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix SSZ BytesN issue #1695

Merged
merged 2 commits into from
Jan 27, 2023
Merged

cluster: fix SSZ BytesN issue #1695

merged 2 commits into from
Jan 27, 2023

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jan 26, 2023

Fixes the SSZ issue that didn't ensure BytesN are always of length N. This is only included in v1.5 onwards.

Also removes the lock.DistributedValidator.FeeRecipient field completely, also for previous versions as this isn't used at all and we do not need to support it for older versions.

category: bug
ticket: #1689

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 54.55% // Head: 54.21% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (cafdf08) compared to base (02c7290).
Patch coverage: 55.66% of modified lines in pull request are covered.

❗ Current head cafdf08 differs from pull request most recent head dfa0bb4. Consider uploading reports for the commit dfa0bb4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1695      +/-   ##
==========================================
- Coverage   54.55%   54.21%   -0.35%     
==========================================
  Files         159      159              
  Lines       20620    20678      +58     
==========================================
- Hits        11250    11210      -40     
- Misses       7876     7957      +81     
- Partials     1494     1511      +17     
Impacted Files Coverage Δ
cluster/lock.go 56.41% <25.00%> (-1.70%) ⬇️
cluster/ssz.go 69.92% <50.00%> (-5.14%) ⬇️
cluster/helpers.go 61.14% <70.00%> (+1.29%) ⬆️
cluster/distvalidator.go 87.50% <100.00%> (-0.97%) ⬇️
core/qbft/qbft.go 73.73% <0.00%> (-10.09%) ⬇️
app/vmock.go 73.05% <0.00%> (-3.11%) ⬇️
app/app.go 63.39% <0.00%> (-0.72%) ⬇️
core/aggsigdb/memory.go 84.44% <0.00%> (+1.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cluster/ssz.go Outdated Show resolved Hide resolved
Co-authored-by: Dhruv Bodani <dhruvbodani2510@gmail.com>
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 27, 2023
@obol-bulldozer obol-bulldozer bot merged commit 43bb5a5 into main Jan 27, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/clusterbytesn branch January 27, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants