compose: add vouch to compose #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 55.20% // Head: 55.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1814 +/- ##
==========================================
- Coverage 55.20% 55.14% -0.06%
==========================================
Files 169 170 +1
Lines 22140 22293 +153
==========================================
+ Hits 12222 12294 +72
- Misses 8355 8419 +64
- Partials 1563 1580 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
corverroos
reviewed
Feb 16, 2023
dB2510
force-pushed
the
dhruv/vouchcompose
branch
from
84f683d
to
e2e1368
Compare
corverroos
approved these changes
Feb 22, 2023
| @@ -173,9 +209,33 @@ func (p *headProducer) handleGetBlockRoot(w http.ResponseWriter, r *http.Request | |||
|
|
|||
| // handleEvents is a http handler to handle "/eth/v1/events". | |||
| func (p *headProducer) handleEvents(w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
should probably add a test for this headProducer, it is pretty complex...
corverroos
approved these changes
Feb 24, 2023
dB2510
added
the
merge when ready
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vouch to compose and also made some changes to beaconmock which were needed by vouch specifically.
Note: Vouch doesn't support block proposals because of RANDAO check in go-eth2-client.
category: feature
ticket: #1403