Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/beaconmock: add static provider #185

Merged
merged 7 commits into from
Mar 7, 2022
Merged

testutil/beaconmock: add static provider #185

merged 7 commits into from
Mar 7, 2022

Conversation

corverroos
Copy link
Contributor

Adds a static values providing beacon mock. This will be required for testing the SigAgg component since it depends on the eth2client.DomainProvider. It adds real world static value to the beaconmock by serving an embedded json file. A script is included to generate the json.

category: testing
ticket: #184

@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@7a504ab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage        ?   51.27%           
=======================================
  Files           ?       42           
  Lines           ?     2627           
  Branches        ?        0           
=======================================
  Hits            ?     1347           
  Misses          ?     1143           
  Partials        ?      137           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a504ab...25ab89d. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much Needed!

// StaticProvider defines a subset of eth2 service providers that
// are served from memory after fetching the data once on startup.
type StaticProvider interface {
eth2client.SpecProvider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can also be in alphabetical order

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@dB2510
Copy link
Contributor

dB2510 commented Mar 7, 2022

@corverroos linter checks are failing

@corverroos corverroos merged commit f0bc829 into main Mar 7, 2022
@corverroos corverroos deleted the corver/static branch March 7, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants