-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testutil/beaconmock: add static provider #185
Conversation
Codecov Report
@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage ? 51.27%
=======================================
Files ? 42
Lines ? 2627
Branches ? 0
=======================================
Hits ? 1347
Misses ? 1143
Partials ? 137 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much Needed!
testutil/beaconmock/static.go
Outdated
// StaticProvider defines a subset of eth2 service providers that | ||
// are served from memory after fetching the data once on startup. | ||
type StaticProvider interface { | ||
eth2client.SpecProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these can also be in alphabetical order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
@corverroos linter checks are failing |
Adds a static values providing beacon mock. This will be required for testing the SigAgg component since it depends on the eth2client.DomainProvider. It adds real world static value to the beaconmock by serving an embedded json file. A script is included to generate the json.
category: testing
ticket: #184