Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: migrate to tracker v2 #1853

Merged
merged 1 commit into from
Mar 3, 2023
Merged

*: migrate to tracker v2 #1853

merged 1 commit into from
Mar 3, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Mar 3, 2023

Migrate to tracker v2 and remove tracker v1 and its references. Also removes tracker_v2 featureflag.

category: refactor
ticket: #1478

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 83.07% and project coverage change: -0.08 ⚠️

Comparison is base (03ed1d8) 55.33% compared to head (2a8ead1) 55.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   55.33%   55.25%   -0.08%     
==========================================
  Files         170      169       -1     
  Lines       22258    21819     -439     
==========================================
- Hits        12316    12057     -259     
+ Misses       8371     8203     -168     
+ Partials     1571     1559      -12     
Impacted Files Coverage Δ
app/featureset/featureset.go 100.00% <ø> (ø)
app/app.go 62.71% <37.50%> (+1.17%) ⬆️
core/tracker/tracker.go 76.62% <85.02%> (+5.51%) ⬆️
app/vmock.go 72.82% <0.00%> (-3.08%) ⬇️
core/leadercast/transport.go 76.33% <0.00%> (+1.18%) ⬆️
core/priority/prioritiser.go 61.79% <0.00%> (+1.41%) ⬆️
core/qbft/qbft.go 82.98% <0.00%> (+9.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 3, 2023
@obol-bulldozer obol-bulldozer bot merged commit bcfa517 into main Mar 3, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/migratetracker branch March 3, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants