p2p: add support for delimited wire protocol upgrades #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
+ Coverage 55.46% 55.56% +0.10%
==========================================
Files 169 169
Lines 21880 21911 +31
==========================================
+ Hits 12135 12175 +40
+ Misses 8191 8180 -11
- Partials 1554 1556 +2
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gsora
approved these changes
Mar 15, 2023
corverroos
added
the
merge when ready
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
Enables delimited versions of all libp2p protocols. category: feature ticket: #1885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for wire protocols to upgrade to length delimited wire messages while still supporting current undelimited messages. This allows a smooth upgrade migration.
Note this hasn't been used yet. Will do that in subsequent PRs.
category: feature
ticket: #1884