p2p: always ensure relay connection #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1903 +/- ##
==========================================
- Coverage 55.47% 55.42% -0.05%
==========================================
Files 172 172
Lines 22073 22085 +12
==========================================
- Hits 12244 12241 -3
- Misses 8253 8269 +16
+ Partials 1576 1575 -1
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
xenowits
approved these changes
Mar 20, 2023
corverroos
added
the
merge when ready
corverroos
added a commit
that referenced
this pull request
Mar 21, 2023
Always ensure active connections to relay. This is required since peers can only connect to you via a relay if you are connected to the relay. This reverts the change introduced in #1816. It also mitigates increase in DKG failures and general "not connected to peer" issues. category: bug ticket: #1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always ensure active connections to relay. This is required since peers can only connect to you via a relay if you are connected to the relay. This reverts the change introduced in #1816. It also mitigates increase in DKG failures and general "not connected to peer" issues.
category: bug
ticket: #1898