core/sigagg: implement signature aggregation #192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage ? 52.43%
=======================================
Files ? 46
Lines ? 2935
Branches ? 0
=======================================
Hits ? 1539
Misses ? 1216
Partials ? 180 Continue to review full report at Codecov.
|
core/sigagg/sigagg.go
Outdated
|
|
||
| var ( | ||
| blsSigs []*bls_sig.PartialSignature | ||
| first core.ParSignedData |
There was a problem hiding this comment.
this variable name can be just data
There was a problem hiding this comment.
It implies we are taking the first data, so does convey extra meaning.
| return err | ||
| } | ||
|
|
||
| if i == 0 { |
There was a problem hiding this comment.
this step can be done to before for loop that way i think we will not need this if else
There was a problem hiding this comment.
Sure, but I like the fact that this means, if it is the first item, use it as reference, also compare the data against the first. If you split it out, then that logic is also split.
| @@ -34,3 +38,90 @@ func RandomPubKey(t *testing.T) core.PubKey { | |||
|
|
|||
| return pubkey | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Thanks for this! this was much needed for tests
Co-authored-by: Dhruv Bodani <dhruvbodani2510@gmail.com>
Implements the core workflow's signature aggregation component.
category: feature
ticket: #184