Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymanager: fixes issues in keymanager API #1930

Merged
merged 8 commits into from
Mar 27, 2023

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Mar 25, 2023

Fixes issues related to keymanager API integration:

  • Fixes json formatting bug
  • Adds --keymanager-auth-token flag to charon dkg. Flag value is redacted when logged
  • Adds --keymanager-auth-tokens flag to charon create cluster command
  • Fixes keymanager-related tests

category: bug
ticket: #1928

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 72.91% and project coverage change: +0.07 🎉

Comparison is base (a331020) 55.53% compared to head (c759e2b) 55.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1930      +/-   ##
==========================================
+ Coverage   55.53%   55.60%   +0.07%     
==========================================
  Files         174      174              
  Lines       22256    22286      +30     
==========================================
+ Hits        12359    12393      +34     
+ Misses       8322     8317       -5     
- Partials     1575     1576       +1     
Impacted Files Coverage Δ
cmd/dkg.go 5.26% <0.00%> (-0.15%) ⬇️
dkg/dkg.go 58.75% <69.23%> (+0.31%) ⬆️
eth2util/keymanager/keymanager.go 73.07% <75.00%> (-4.54%) ⬇️
cmd/createcluster.go 59.59% <85.71%> (+0.11%) ⬆️
cmd/cmd.go 81.48% <100.00%> (+0.52%) ⬆️
dkg/disk.go 64.24% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/createcluster.go Outdated Show resolved Hide resolved
eth2util/keymanager/keymanager.go Outdated Show resolved Hide resolved
eth2util/keymanager/keymanager.go Outdated Show resolved Hide resolved
eth2util/keymanager/keymanager.go Outdated Show resolved Hide resolved
@xenowits
Copy link
Contributor Author

xenowits commented Mar 27, 2023

Successful keymanager import keys with create cluster command:
Screenshot 2023-03-27 at 12 03 01

Error message when lengths don't match with create cluster command:
Screenshot 2023-03-27 at 12 15 49

Successful keymanager import keys with charon dkg command:
Screenshot 2023-03-27 at 12 44 36

@xenowits
Copy link
Contributor Author

Note that --keymanager-auth-token is redacted in logged parsed config:
Screenshot 2023-03-27 at 13 09 41

Screenshot 2023-03-27 at 13 10 33

Screenshot 2023-03-27 at 13 11 16

cmd/cmd.go Show resolved Hide resolved
cmd/cmd.go Outdated Show resolved Hide resolved
dkg/dkg.go Outdated Show resolved Hide resolved
eth2util/keymanager/keymanager.go Outdated Show resolved Hide resolved
@xenowits xenowits self-assigned this Mar 27, 2023
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 27, 2023
@obol-bulldozer obol-bulldozer bot merged commit ed06491 into main Mar 27, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/fix-keymanager branch March 27, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants