Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg: fix race condition in keycast #1942

Merged
merged 2 commits into from
Mar 27, 2023
Merged

dkg: fix race condition in keycast #1942

merged 2 commits into from
Mar 27, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Mar 27, 2023

Fixes race condition in keycast for concurrent write of map.

category: bug
ticket: #1867

dkg/keycast.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (f2dd396) 55.35% compared to head (da89ce3) 55.34%.

❗ Current head da89ce3 differs from pull request most recent head ff8b256. Consider uploading reports for the commit ff8b256 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1942      +/-   ##
==========================================
- Coverage   55.35%   55.34%   -0.02%     
==========================================
  Files         174      174              
  Lines       22253    22260       +7     
==========================================
+ Hits        12319    12320       +1     
- Misses       8360     8364       +4     
- Partials     1574     1576       +2     
Impacted Files Coverage Δ
dkg/keycast.go 71.87% <100.00%> (+0.72%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Mar 27, 2023
@obol-bulldozer obol-bulldozer bot merged commit 2d59b68 into main Mar 27, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/keycastrace branch March 27, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants