p2p: move ActivationThresh in a sync.Once #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guarantees that identify.ActivationThresh is only initialized once, on the first call to NewTCPNode.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 55.53% 55.45% -0.08%
==========================================
Files 174 174
Lines 22256 22295 +39
==========================================
+ Hits 12359 12363 +4
- Misses 8322 8358 +36
+ Partials 1575 1574 -1
... and 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gsora
added
the
merge when ready
corverroos
approved these changes
Mar 27, 2023
| @@ -28,10 +29,18 @@ import ( | |||
| "github.com/obolnetwork/charon/app/z" | |||
| ) | |||
|
|
|||
| var activationThreshOnce = sync.Once{} | |||
There was a problem hiding this comment.
nit: var activationThreshOnce sync.Once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarantees that identify.ActivationThresh is only initialized once, on the first call to NewTCPNode.
category: bug
ticket: #1867