-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/aggsigdb: refactor concurrent access issue in test #1950
Conversation
Use sync.Map with a thin abstraction for data and keys by duty maps.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
=======================================
Coverage ? 55.45%
=======================================
Files ? 174
Lines ? 22344
Branches ? 0
=======================================
Hits ? 12391
Misses ? 8373
Partials ? 1580
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This way we synchronize based off map's interaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aggsigdb has a central goroutine that accesses all state, so sycnronisation not required. If race is due to tests, rather use callback functions called by that central goroutine.
Will fix the test instead. |
Reopened with a new approach. LMK what you think @corverroos. |
Use sync.Map with a thin abstraction for data and keys by duty maps.
category: bug
ticket: #1867