app: add readyz error when BN can't sync because of zero peers #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grafana preview: |
corverroos
approved these changes
Mar 29, 2023
corverroos
reviewed
Mar 29, 2023
xenowits
force-pushed
the
xenowits/fix-bn-issue
branch
from
5c1a08f
to
e6d9e8e
Compare
xenowits
added
the
merge when ready
xenowits
force-pushed
the
xenowits/fix-bn-issue
branch
from
e6d9e8e
to
63a686a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1961 +/- ##
==========================================
+ Coverage 53.19% 55.52% +2.32%
==========================================
Files 174 174
Lines 22367 22320 -47
==========================================
+ Hits 11899 12393 +494
+ Misses 8964 8344 -620
- Partials 1504 1583 +79
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
LukeHackett12
pushed a commit
that referenced
this pull request
Apr 11, 2023
Adds a new `readyz` error for scenarios when beacon node cannot sync because of zero peers. Without this fix, the grafana healthy panel shows "OK". `IsSyncing: false` means that the "Beacon node is not syncing" because either - "It is fully synced" OR - "Can't sync as it has no peers" category: bug ticket: #1732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
readyzerror for scenarios when beacon node cannot sync because of zero peers. Without this fix, the grafana healthy panel shows "OK".IsSyncing: falsemeans that the "Beacon node is not syncing" because eithercategory: bug
ticket: #1732