Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/eth2wrap: fix lazy client if http times out #2038

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

corverroos
Copy link
Contributor

Fix eth2wrap lazy client when http requests block/timeout. Also respect context cancel while lazy resolving.

category: bug
ticket: #2037
cherry-pick: #2035

Fix eth2wrap lazy client when http requests block/timeout. Also respect context cancel while lazy resolving.

category: bug
ticket: none
@corverroos corverroos added the branch-release PR or Issue linked to a release branch (not main) label Apr 6, 2023
@corverroos corverroos changed the title app/eth2wrap: fix lazy client if http times out (#2035) app/eth2wrap: fix lazy client if http times out Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main-v0.15@1dae9e2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             main-v0.15    #2038   +/-   ##
=============================================
  Coverage              ?   53.40%           
=============================================
  Files                 ?      174           
  Lines                 ?    22493           
  Branches              ?        0           
=============================================
  Hits                  ?    12013           
  Misses                ?     8973           
  Partials              ?     1507           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 6, 2023
@obol-bulldozer obol-bulldozer bot merged commit bd2d6e3 into main-v0.15 Apr 6, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/v0.15/fixlazy branch April 6, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants