Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracker: improve participation #2112

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Apr 19, 2023

Improves participation metric to count multiple duties per slot. For example, we can have multiple attester duties per slot.

category: feature
ticket: #2034

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -0.39 ⚠️

Comparison is base (889cba4) 53.82% compared to head (6edf32d) 53.44%.

❗ Current head 6edf32d differs from pull request most recent head 3a31372. Consider uploading reports for the commit 3a31372 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   53.82%   53.44%   -0.39%     
==========================================
  Files         172      172              
  Lines       22282    22395     +113     
==========================================
- Hits        11994    11968      -26     
- Misses       8840     8970     +130     
- Partials     1448     1457       +9     
Impacted Files Coverage Δ
core/tracker/tracker.go 79.91% <72.72%> (+0.65%) ⬆️

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/tracker/tracker.go Outdated Show resolved Hide resolved
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 21, 2023
@obol-bulldozer obol-bulldozer bot merged commit fb085b2 into main Apr 21, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/trackerparticipation branch April 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants