Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/consensus: improve simulator test #2116

Merged
merged 3 commits into from
Apr 23, 2023
Merged

core/consensus: improve simulator test #2116

merged 3 commits into from
Apr 23, 2023

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Apr 21, 2023

Improve consensus round timer silmulator test.

category: test
ticket: #2117

@corverroos
Copy link
Contributor Author

Example output: matrix.txt

Conclusions:

  • medium size cluster is looking best, small-global is worst
  • Does seem like double is better than inc, slightly more undecideds, but much better avg duration
  • if you must come to consensus, and you are willing to sacrifice avg duration, then exponential is the way to go
  • outlier is first line... this doesn't make sense...?

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.26 🎉

Comparison is base (139e45d) 53.52% compared to head (bfb2e9e) 53.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2116      +/-   ##
==========================================
+ Coverage   53.52%   53.79%   +0.26%     
==========================================
  Files         173      173              
  Lines       22457    22485      +28     
==========================================
+ Hits        12021    12096      +75     
+ Misses       8981     8935      -46     
+ Partials     1455     1454       -1     
Impacted Files Coverage Δ
app/log/config.go 79.36% <0.00%> (-1.61%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/consensus/strategysim_internal_test.go Outdated Show resolved Hide resolved
Co-authored-by: Dhruv Bodani <dhruvbodani2510@gmail.com>
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 23, 2023
@obol-bulldozer obol-bulldozer bot merged commit be8fb70 into main Apr 23, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/simmore branch April 23, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants