Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/consensus: change round AB test timers #2213

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

corverroos
Copy link
Contributor

Refactors the roundtimer AB testing candidates: Just the legacy inc and the new eager_dlinear. This is after simulation benchmarking showed that the following timer would work best:

  • eager, so start times are aligned between all nodes.
  • double, doubles round times if pre-prepare is detected (extended round with valid leaders).
  • linear, 1s, 2s, 3s, which means 4 round in 10s, which should be enough for almost all clusters.

category: refactor
ticket: #2117

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fb6aa21) 53.68% compared to head (791557b) 53.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2213   +/-   ##
=======================================
  Coverage   53.68%   53.69%           
=======================================
  Files         186      186           
  Lines       24261    24248   -13     
=======================================
- Hits        13025    13020    -5     
+ Misses       9629     9622    -7     
+ Partials     1607     1606    -1     
Impacted Files Coverage Δ
core/consensus/roundtimer.go 100.00% <100.00%> (+3.07%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 19, 2023
@obol-bulldozer obol-bulldozer bot merged commit a0cf658 into main May 19, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/abtesttimers branch May 19, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants