Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: add NodeSignatures to create cluster #2250

Merged
merged 1 commit into from
May 30, 2023
Merged

cmd: add NodeSignatures to create cluster #2250

merged 1 commit into from
May 30, 2023

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented May 29, 2023 •
edited

Makes charon create cluster command feature-complete with regards to charon dkg execution output.

category: feature
ticket: #2204

@gsora gsora requested a review from corverroos May 29, 2023 13:50
@gsora gsora self-assigned this May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01 ⚠️

Comparison is base (51c3863) 53.80% compared to head (230c5b3) 53.80%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
- Coverage   53.80%   53.80%   -0.01%     
==========================================
  Files         188      188              
  Lines       25444    25461      +17     
==========================================
+ Hits        13691    13700       +9     
- Misses      10070    10077       +7     
- Partials     1683     1684       +1
Impacted Files Coverage Δ
cmd/createcluster.go 58.63% <66.66%> (+0.16%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

xenowits
xenowits approved these changes May 29, 2023
View reviewed changes
Copy link
Contributor

@xenowits xenowits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xenowits xenowits mentioned this pull request May 29, 2023
Closed
5 tasks
@corverroos corverroos changed the title cmd: write NodeSignatures lock file field cmd: add NodeSignatures to create cluster May 30, 2023
@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 30, 2023
@obol-bulldozer obol-bulldozer bot merged commit c8f5c4c into main May 30, 2023
15 of 16 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/nodesigs_create_cluster branch May 30, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corverroos corverroos corverroos approved these changes

@xenowits xenowits xenowits approved these changes

Assignees

@gsora gsora

Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gsora @corverroos @xenowits