p2p: add stream counter metric #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a closure with the blocking ping logic so that it's easier to understand and defer ping stream context's.
Adds `peer_streams` gauge with the following description: ""Current number of libp2p streams by peer and direction ('inbound' or 'outbound' or 'unknown').".
xenowits
reviewed
Jun 5, 2023
corverroos
reviewed
Jun 5, 2023
This reverts commit 00494c3.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2278 +/- ##
==========================================
- Coverage 53.80% 53.72% -0.08%
==========================================
Files 188 188
Lines 25542 25563 +21
==========================================
- Hits 13742 13733 -9
- Misses 10113 10145 +32
+ Partials 1687 1685 -2
☔ View full report in Codecov by Sentry. |
corverroos
suggested changes
Jun 5, 2023
corverroos
approved these changes
Jun 5, 2023
Don't need in prod, we're going to remove them once we fix the steam leak issue
dB2510
approved these changes
Jun 5, 2023
dB2510
added
the
merge when ready
corverroos
pushed a commit
that referenced
this pull request
Jun 8, 2023
Adds a Prometheus metric to track the opened streams by protocol. category: bug ticket: #2277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Prometheus metric to track the opened streams by protocol.
category: bug
ticket: #2277