Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add charon alpha add-validators-solo command #2280

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Jun 5, 2023

Adds charon alpha add-validators-solo command to cmd package. It doesn't contain the actual functionality for adding validators.

category: feature
ticket: #1887

@xenowits xenowits self-assigned this Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 38.59% and project coverage change: -0.09 ⚠️

Comparison is base (0f2b40f) 53.80% compared to head (801ca84) 53.71%.

❗ Current head 801ca84 differs from pull request most recent head 1f7841f. Consider uploading reports for the commit 1f7841f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
- Coverage   53.80%   53.71%   -0.09%     
==========================================
  Files         188      190       +2     
  Lines       25542    25599      +57     
==========================================
+ Hits        13742    13750       +8     
- Misses      10113    10162      +49     
  Partials     1687     1687              
Impacted Files Coverage Δ
cmd/alpha.go 0.00% <0.00%> (ø)
cmd/cmd.go 80.83% <0.00%> (-2.08%) ⬇️
cmd/addvalidators.go 50.00% <50.00%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/alpha.go Outdated Show resolved Hide resolved
cmd/addvalidators.go Show resolved Hide resolved
cmd/addvalidators.go Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 6, 2023
@obol-bulldozer obol-bulldozer bot merged commit 33f3550 into main Jun 6, 2023
9 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/alpha-add-validators branch June 6, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants