core: enable ssz encoding in protos #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
==========================================
- Coverage 53.81% 53.76% -0.05%
==========================================
Files 190 190
Lines 25628 25628
==========================================
- Hits 13792 13780 -12
- Misses 10150 10164 +14
+ Partials 1686 1684 -2
☔ View full report in Codecov by Sentry. |
dB2510
reviewed
Jun 6, 2023
core/ssz_test.go
Outdated
Comment on lines
205
to
208
| if disabledSSZ { | ||
| sszSizes[fmt.Sprintf("%T", signedPtr)] = len(b) | ||
| } else { | ||
| jsonSizes[fmt.Sprintf("%T", signedPtr)] = len(b) |
There was a problem hiding this comment.
Shouldn't this be?:
Suggested change
| if disabledSSZ { | |
| sszSizes[fmt.Sprintf("%T", signedPtr)] = len(b) | |
| } else { | |
| jsonSizes[fmt.Sprintf("%T", signedPtr)] = len(b) | |
| if disabledSSZ { | |
| jsonSizes[fmt.Sprintf("%T", signedPtr)] = len(b) | |
| } else { | |
| sszSizes[fmt.Sprintf("%T", signedPtr)] = len(b) |
There was a problem hiding this comment.
cheers thanks fixed
dB2510
approved these changes
Jun 6, 2023
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables SSZ encoding in protos by default. This decreases wire bandwitdh requirements.
category: feature
ticket: #2203