testutil/validatormock: error instead of panic #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
- Coverage 53.67% 53.55% -0.12%
==========================================
Files 192 192
Lines 25833 25864 +31
==========================================
- Hits 13865 13851 -14
- Misses 10250 10297 +47
+ Partials 1718 1716 -2
☔ View full report in Codecov by Sentry. |
corverroos
added
the
merge when ready
xenowits
pushed a commit
that referenced
this pull request
Jun 26, 2023
Refactors validator mock logic to error when state already set (instead of panic). Also use explicit slot/poch to store stateful objects, rather then implicit "last slot" since out of order slot scheduling should cause problems. category: test ticket: #2347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors validator mock logic to error when state already set (instead of panic). Also use explicit slot/poch to store stateful objects, rather then implicit "last slot" since out of order slot scheduling should cause problems.
category: test
ticket: #2347