Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: remove support for legacy stream delimited protocols #2350

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

corverroos
Copy link
Contributor

Removes support for legacy stream delimited libp2p protocols. Only support length-delimited protocols.

category: refactor
ticket: #1934

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.12 ⚠️

Comparison is base (347a50a) 53.67% compared to head (9177897) 53.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
- Coverage   53.67%   53.55%   -0.12%     
==========================================
  Files         192      192              
  Lines       25833    25805      -28     
==========================================
- Hits        13865    13821      -44     
- Misses      10250    10268      +18     
+ Partials     1718     1716       -2     
Impacted Files Coverage Δ
dkg/bcast/server.go 70.42% <ø> (ø)
core/parsigex/parsigex.go 62.79% <33.33%> (ø)
core/consensus/component.go 65.81% <50.00%> (ø)
app/peerinfo/peerinfo.go 67.77% <75.00%> (-6.12%) ⬇️
app/peerinfo/adhoc.go 76.92% <100.00%> (ø)
core/consensus/transport.go 70.37% <100.00%> (-0.22%) ⬇️
core/priority/prioritiser.go 62.32% <100.00%> (+2.79%) ⬆️
dkg/bcast/client.go 81.25% <100.00%> (ø)
dkg/frostp2p.go 75.30% <100.00%> (ø)
p2p/sender.go 74.34% <100.00%> (-0.52%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 22, 2023
@obol-bulldozer obol-bulldozer bot merged commit 7374a44 into main Jun 22, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/removedelim branch June 22, 2023 14:20
xenowits pushed a commit that referenced this pull request Jun 26, 2023
Removes support for legacy stream delimited libp2p protocols. Only support length-delimited protocols.

category: refactor
ticket: #1934
dB2510 added a commit that referenced this pull request Jun 30, 2023
@dB2510 dB2510 mentioned this pull request Jun 30, 2023
obol-bulldozer bot pushed a commit that referenced this pull request Jun 30, 2023
Reverts #2350 

category: refactor
ticket: #1934
obol-bulldozer bot pushed a commit that referenced this pull request Aug 1, 2023
Removes support for legacy stream delimited libp2p protocols. Only support length-delimited protocols.
Note: this PR is clone of #2350 

category: refactor
ticket: #1934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants