Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth2util: support legacy signed randao marshalling #2353

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jun 23, 2023

Workaround to marshal SignedRandao using legacy [96]byte signature marshalling to remain compatible with v0.16.

This was discovered by go-eth2-client that added proper json marshalling using 0xhex strings for eth2p0.BLSSignature.

This starts the following migration:

  • v0.16 marshals legacy and unmarshals legacy only.
  • v0.17 marshals legacy, but supports unmarshalling both new and legacy.
  • v0.18 will marshal new, but will support unmarshalling both new and legacy
  • v0.19 will marshal new and will unmarshals new only

category: bug
ticket: #2333

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 27.77% and project coverage change: +0.21 🎉

Comparison is base (7374a44) 53.49% compared to head (42d13cf) 53.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
+ Coverage   53.49%   53.71%   +0.21%     
==========================================
  Files         192      192              
  Lines       25847    25862      +15     
==========================================
+ Hits        13827    13891      +64     
+ Misses      10308    10249      -59     
- Partials     1712     1722      +10     
Impacted Files Coverage Δ
eth2util/types.go 43.47% <27.77%> (+11.22%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 26, 2023
@obol-bulldozer obol-bulldozer bot merged commit bd7ce4b into main Jun 26, 2023
14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/sigjson branch June 26, 2023 11:46
obol-bulldozer bot pushed a commit that referenced this pull request Aug 22, 2023
Support marshalling 0xhex signatures for SignedEpoch as part of migration started in #2353. Next step is to remove support for legacy signatures completely.

category: refactor
ticket: #2353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants