Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add logs #2377

Merged
merged 2 commits into from
Jul 3, 2023
Merged

cmd: add logs #2377

merged 2 commits into from
Jul 3, 2023

Conversation

xenowits
Copy link
Contributor

Adds --log-level flag and additional logs to add-validators-solo command.

category: feature
ticket: #1887

@xenowits xenowits self-assigned this Jun 30, 2023
@xenowits
Copy link
Contributor Author

With debug logs:
Screenshot 2023-06-30 at 15 02 21

With info logs:
Screenshot 2023-06-30 at 15 03 21

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 60.60% and project coverage change: -0.26 ⚠️

Comparison is base (aba2bb5) 53.85% compared to head (e57d5c9) 53.59%.

❗ Current head e57d5c9 differs from pull request most recent head 5175689. Consider uploading reports for the commit 5175689 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2377      +/-   ##
==========================================
- Coverage   53.85%   53.59%   -0.26%     
==========================================
  Files         192      192              
  Lines       25961    25964       +3     
==========================================
- Hits        13980    13915      -65     
- Misses      10257    10323      +66     
- Partials     1724     1726       +2     
Impacted Files Coverage Δ
cmd/addvalidators.go 52.94% <60.60%> (+1.29%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd/addvalidators.go Outdated Show resolved Hide resolved
@xenowits xenowits requested a review from corverroos July 3, 2023 10:55
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 3, 2023
@obol-bulldozer obol-bulldozer bot merged commit e90d962 into main Jul 3, 2023
10 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/improve-logging branch July 3, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants