cmd: write deposit datas to disk #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2395 +/- ##
==========================================
- Coverage 53.42% 53.35% -0.07%
==========================================
Files 196 196
Lines 26254 26282 +28
==========================================
- Hits 14025 14024 -1
- Misses 10490 10520 +30
+ Partials 1739 1738 -1
☔ View full report in Codecov by Sentry. |
corverroos
suggested changes
Jul 4, 2023
corverroos
reviewed
Jul 4, 2023
cmd/addvalidators.go
Outdated
| return err | ||
| } | ||
|
|
||
| filename := fmt.Sprintf("deposit-data-%s.pb", currTime) // Ex: "cluster-manifest-backup-20060102150405.pb" |
There was a problem hiding this comment.
we need to log that this is the new deposit datas that was created
There was a problem hiding this comment.
Yes, we do log this:
17:56:16.246 DEBG cmd Saved deposit data file to disk {"deposit_data": "deposit-data-20230704175616.json"}
Logs:
Node directory:
corverroos
approved these changes
Jul 5, 2023
gsora
approved these changes
Jul 5, 2023
xenowits
force-pushed
the
xenowits/create-deposit-datas
branch
from
905bd83
to
89939de
Compare
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write deposit data file for new validators created in
add-validators-solocommand to each node directory. The new deposit files are named asdeposit-data-20230704173152.json.Also deletes logic for backing up cluster manifests.
category: feature
ticket: #2379