Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/consensus: refactor duration metric #2425

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

corverroos
Copy link
Contributor

Refactors the consensus duration metric to duration=consensus_decided_at-consensus_proposed_at so that eager timer durations are reflected correctly since they start much earlier than normal timing strategies.

category: refactor
ticket: #2337

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 86.95% and project coverage change: +0.02 🎉

Comparison is base (f6e7c24) 53.71% compared to head (03e27cf) 53.73%.

❗ Current head 03e27cf differs from pull request most recent head b820c4d. Consider uploading reports for the commit b820c4d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2425      +/-   ##
==========================================
+ Coverage   53.71%   53.73%   +0.02%     
==========================================
  Files         199      198       -1     
  Lines       26467    26462       -5     
==========================================
+ Hits        14216    14220       +4     
+ Misses      10483    10479       -4     
+ Partials     1768     1763       -5     
Impacted Files Coverage Δ
core/consensus/component.go 66.82% <86.95%> (+1.00%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/consensus/component.go Outdated Show resolved Hide resolved
Co-authored-by: Gianguido Sorà <gsora@users.noreply.github.com>
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 13, 2023
@obol-bulldozer obol-bulldozer bot merged commit 79116f9 into main Jul 13, 2023
10 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/consduration branch July 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants