cluster: align hash timestamp to unix #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
==========================================
+ Coverage 53.71% 53.88% +0.17%
==========================================
Files 199 198 -1
Lines 26467 26458 -9
==========================================
+ Hits 14216 14257 +41
+ Misses 10483 10438 -45
+ Partials 1768 1763 -5
☔ View full report in Codecov by Sentry. |
corverroos
suggested changes
Jul 14, 2023
cluster/ssz.go
Outdated
| @@ -695,7 +697,7 @@ func hashRegistration(r Registration, hh ssz.HashWalker) error { | |||
| hh.PutUint64(uint64(r.GasLimit)) | |||
|
|
|||
| // Field (2) 'Timestamp' Bytes48 | |||
| hh.PutBytes([]byte(r.Timestamp.String())) | |||
| hh.PutBytes([]byte(r.Timestamp.Format(time.RFC3339))) | |||
There was a problem hiding this comment.
please use eth2 standard of ssz marshalling, also please ensure this hash equals canonical ssz hashing of validator registration
dB2510
changed the title
corverroos
approved these changes
Jul 17, 2023
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns timestamp format of validator registration in hash calculation to unix format. This is done to avoid any confusion between timestamp in
cluster-lock.jsonand the format used to calculate lock hash. Also it aligns the timestamp format with that ofgo-eth2-clienttypes.category: bug
ticket: #2436