Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsigex: unmarshal data that is about to be broadcasted #2434

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jul 14, 2023

Also log full hex encoded byte arrays that fail to get unmarshaled in their original type.

Needed to troubleshoot #2433.

category: misc
ticket: #2433

Also log full hex encoded byte arrays that fail to get unmarshaled in their original type.

Needed to troubleshoot #2433.
@gsora gsora requested a review from corverroos July 14, 2023 14:03
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (a082b7c) 53.84% compared to head (07f5f10) 53.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
- Coverage   53.84%   53.77%   -0.08%     
==========================================
  Files         198      198              
  Lines       26466    26471       +5     
==========================================
- Hits        14251    14234      -17     
- Misses      10450    10468      +18     
- Partials     1765     1769       +4     
Impacted Files Coverage Δ
core/parsigex/parsigex.go 60.67% <0.00%> (-2.12%) ⬇️
core/proto.go 62.63% <0.00%> (-0.67%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/proto.go Show resolved Hide resolved
core/parsigex/parsigex.go Outdated Show resolved Hide resolved
@gsora gsora requested a review from corverroos July 14, 2023 14:36
@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 14, 2023
@obol-bulldozer obol-bulldozer bot merged commit 6075930 into main Jul 14, 2023
12 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/parsigex_unmarshal_logs branch July 14, 2023 14:57
gsora added a commit that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants