cmd: fix create cluster regression
#2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the `create cluster` refactor a couple PR's back, definition file was essentially ignored. This PR restores that functionality back,
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2445 +/- ##
==========================================
+ Coverage 53.72% 53.79% +0.06%
==========================================
Files 198 198
Lines 26478 26502 +24
==========================================
+ Hits 14226 14256 +30
+ Misses 10490 10483 -7
- Partials 1762 1763 +1
☔ View full report in Codecov by Sentry. |
corverroos
suggested changes
Jul 18, 2023
corverroos
reviewed
Jul 19, 2023
corverroos
reviewed
Jul 19, 2023
cmd/createcluster.go
Outdated
| @@ -152,22 +147,30 @@ func runCreateCluster(ctx context.Context, w io.Writer, conf clusterConfig) erro | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| conf.FeeRecipientAddrs = def.FeeRecipientAddresses() | |||
There was a problem hiding this comment.
it feels like definition is the source of truth from this point, why is it required to update the config? The else statement creates a definition from the config, feels like we should just use definition from this point forward
…e of splitkeys with definition and mismatching amount of validators
corverroos
approved these changes
Jul 26, 2023
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the
create clusterrefactor a couple PR's back, definition file was essentially ignored.This PR restores that functionality back.
category: bug
ticket: #2444
Closes #2444