core/consensus: error on subsequent calls #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
+ Coverage 53.72% 53.77% +0.04%
==========================================
Files 198 198
Lines 26478 26496 +18
==========================================
+ Hits 14226 14247 +21
+ Misses 10490 10483 -7
- Partials 1762 1766 +4
☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Jul 18, 2023
xenowits
reviewed
Jul 18, 2023
dB2510
approved these changes
Jul 18, 2023
xenowits
approved these changes
Jul 18, 2023
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
corverroos
added
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error when either
ParticipateorProposeis called multiple times for the same duty since this results in goroutines hanging forever.Also removes debug logs.
category: refactor
ticket: #2439