dkg: exchange sigTypes concurrently #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, calling `exchange()` would listen for new incoming messages and discard everything that didn't carry the expected sigType. In a DKG one node might fall behind the others (for example, while DKG'ing 3000 validator keys) and send sigTypes that the other peers have already received threshold for. This commit makes sure a given instance of `exchanger` will hold onto all messages whose sigTypes are specified during its initialization phase. Calling `exchange()` will return as soon as there are enough messages for the specified sigType, but different sigTypes messages will still be stored and will be returned when requested by means of another `exchange()` call, with a different sigType argument.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2496 +/- ##
==========================================
+ Coverage 53.52% 53.70% +0.18%
==========================================
Files 198 199 +1
Lines 26757 26813 +56
==========================================
+ Hits 14321 14400 +79
+ Misses 10648 10626 -22
+ Partials 1788 1787 -1
☔ View full report in Codecov by Sentry. |
corverroos
reviewed
Aug 1, 2023
corverroos
reviewed
Aug 2, 2023
| } | ||
|
|
||
| // set sets data for the given sigType and core.PubKey. | ||
| func (stb *dataByPubkey) set(pubKey core.PubKey, sigType sigType, data []core.ParSignedData) { |
There was a problem hiding this comment.
can refactor this to take a single sigdata parameter
corverroos
reviewed
Aug 2, 2023
| type sigTypeStore map[sigType]map[core.PubKey][]core.ParSignedData | ||
|
|
||
| // dataByPubkey maps a sigType to its map of public key to slice of core.ParSignedData.. | ||
| type dataByPubkey struct { |
There was a problem hiding this comment.
personal style: I would not introduce more types. I would just put the lock and a map[sigType]sigData in exchanger itself.
func (e exchanger) set(sigdata) {...}
func (e exchanger) get(sigtype) (sigdata, bool) {...}
But that is just me #lessismore
Avoids a goroutine and channel interaction
corverroos
approved these changes
Aug 2, 2023
|
LGTM |
gsora
added
the
merge when ready
gsora
added a commit
that referenced
this pull request
Aug 9, 2023
Before this commit, calling `exchange()` would listen for new incoming messages and discard everything that didn't carry the expected `sigType`. In a DKG one node might fall behind the others (for example, while DKG'ing 3000 validator keys) and send `sigTypes` that the other peers have already received threshold for. This PR makes sure a given instance of `exchanger` will hold onto all messages whose `sigTypes` are specified during its initialization phase. Calling `exchange()` will return as soon as there are enough messages for the specified `sigType`, but different `sigType`s messages will still be stored and will be returned when requested by means of another `exchange()` call, with a different `sigType` argument. category: bug ticket: #2491 Closes #2491.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, calling
exchange()would listen for new incoming messages and discard everything that didn't carry the expectedsigType.In a DKG one node might fall behind the others (for example, while DKG'ing 3000 validator keys) and send
sigTypesthat the other peers have already received threshold for.This PR makes sure a given instance of
exchangerwill hold onto all messages whosesigTypesare specified during its initialization phase.Calling
exchange()will return as soon as there are enough messages for the specifiedsigType, but differentsigTypes messages will still be stored and will be returned when requested by means of anotherexchange()call, with a differentsigTypeargument.category: bug
ticket: #2491
Closes #2491.