Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/keystore: use hardcoded password #258

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Use hardcoded "simnet" password for keystores since VCs like lighthouse do not support empty passwords when importing keystores.

category: feature
ticket: #251

@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #258 (b6da27f) into main (dc35136) will increase coverage by 0.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   55.08%   55.78%   +0.70%     
==========================================
  Files          51       53       +2     
  Lines        3571     3671     +100     
==========================================
+ Hits         1967     2048      +81     
- Misses       1327     1345      +18     
- Partials      277      278       +1     
Impacted Files Coverage Δ
testutil/keystore/keystore.go 50.68% <100.00%> (ø)
core/aggsigdb/memory.go 84.04% <0.00%> (ø)
core/aggsigdb/stub.go 0.00% <0.00%> (ø)
core/types.go 4.25% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc35136...b6da27f. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corverroos corverroos merged commit 55103ac into main Mar 21, 2022
@corverroos corverroos deleted the corver/keystorepass branch March 21, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants