Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth2util: add holesky #2590

Merged
merged 3 commits into from
Sep 20, 2023
Merged

eth2util: add holesky #2590

merged 3 commits into from
Sep 20, 2023

Conversation

xenowits
Copy link
Contributor

Add holesky to the list of supported networks.

category: feature
ticket: #2399

@xenowits xenowits self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023 •
edited

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.03% 🎉

Comparison is base (1ca2b47) 53.77% compared to head (208f79c) 53.80%.

❗ Current head 208f79c differs from pull request most recent head a09937b. Consider uploading reports for the commit a09937b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
+ Coverage   53.77%   53.80%   +0.03%     
==========================================
  Files         200      200              
  Lines       27132    27132              
==========================================
+ Hits        14589    14599      +10     
+ Misses      10719    10710       -9     
+ Partials     1824     1823       -1
Files Changed Coverage Δ
cmd/createcluster.go 59.82% <0.00%> (ø)
eth2util/network.go 67.39% <ø> (ø)
cmd/createdkg.go 72.58% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LukeHackett12
LukeHackett12 reviewed Sep 18, 2023
View reviewed changes
eth2util/network.go Outdated Show resolved Hide resolved
LukeHackett12
LukeHackett12 reviewed Sep 19, 2023
View reviewed changes
eth2util/network.go Outdated Show resolved Hide resolved
@xenowits @LukeHackett12
Update eth2util/network.go
208f79c 
Co-authored-by: Luke Hackett <luke@obol.tech>
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 20, 2023
@obol-bulldozer obol-bulldozer bot merged commit 341cc7b into main Sep 20, 2023
10 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/add-holesky branch September 20, 2023 16:31
dB2510 pushed a commit that referenced this pull request Oct 9, 2023
@xenowits @dB2510
eth2util: add holesky (#2590)
c8cab1f 
Add `holesky` to the list of supported networks.

category: feature 
ticket: #2399
@dB2510 dB2510 mentioned this pull request Oct 9, 2023
Merged
obol-bulldozer bot pushed a commit that referenced this pull request Oct 9, 2023
@dB2510
eth2util: add holesky (#2628)
36e5445 
Add `holesky` to the list of supported networks.

Cherry-pick: #2590 

category: feature 
ticket: #2399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeHackett12 LukeHackett12 LukeHackett12 approved these changes

Assignees

@xenowits xenowits

Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xenowits @LukeHackett12