eth2util: fix fork version #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
==========================================
+ Coverage 53.67% 53.75% +0.07%
==========================================
Files 200 200
Lines 27132 27132
==========================================
+ Hits 14564 14585 +21
+ Misses 10745 10725 -20
+ Partials 1823 1822 -1
☔ View full report in Codecov by Sentry. |
xenowits
approved these changes
Sep 28, 2023
| @@ -54,7 +54,7 @@ var ( | |||
| Holesky = Network{ | |||
| ChainID: 17000, | |||
| Name: "holesky", | |||
| GenesisForkVersionHex: "0x00017000", | |||
| GenesisForkVersionHex: "0x01017000", | |||
There was a problem hiding this comment.
Can you please add a link to where this is mentioned?
There was a problem hiding this comment.
LukeHackett12
added
the
merge when ready
dB2510
pushed a commit
that referenced
this pull request
Oct 9, 2023
Fix holesky genesis fork version. category: bug ticket: none
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Fix holesky genesis fork version. Cherry-pick: #2600 category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix holesky genesis fork version.
category: bug
ticket: #2601