core/validatorapi: fix attestation domain and signature verification #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 57.30% 58.68% +1.38%
==========================================
Files 53 53
Lines 3904 3957 +53
==========================================
+ Hits 2237 2322 +85
+ Misses 1357 1316 -41
- Partials 310 319 +9
Continue to review full report at Codecov.
|
dB2510
approved these changes
Mar 22, 2022
| @@ -124,12 +124,12 @@ func NewSigner(secrets ...*bls_sig.SecretKey) SignFunc { | |||
| return eth2p0.BLSSignature{}, err | |||
| } | |||
|
|
|||
| msg, err := data.MarshalSSZ() | |||
| msg, err := data.HashTreeRoot() | |||
There was a problem hiding this comment.
how did you found out that actual msg should be HashTreeRoot not MarshalSSZ?
There was a problem hiding this comment.
When I implemented this tests from prsym.
// TestSignAndVerify signs and verifies the signature.
// Test input and output obtained from prysm/validator/client/attest_test.go#TestSignAttestation.
func TestSignAndVerify(t *testing.T) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with signature verification and creation.
category: bug
ticket: #251