Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: revert core interfaces #2682

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Nov 7, 2023

Revert changes to core interfaces.

This is done since the deneb upgrade no longer requires multiple signatures per signed object. Reverting to the original implementation makes the interfaces simple and code much easier to reason about.

category: refactor
ticket: #2659

@xenowits xenowits self-assigned this Nov 7, 2023
@xenowits xenowits changed the title revert core interfaces core: revert core interfaces Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (7172fb6) 53.06% compared to head (5965599) 53.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2682      +/-   ##
==========================================
+ Coverage   53.06%   53.42%   +0.35%     
==========================================
  Files         202      202              
  Lines       27999    27780     -219     
==========================================
- Hits        14858    14841      -17     
+ Misses      11282    11099     -183     
+ Partials     1859     1840      -19     
Files Coverage Δ
cmd/createcluster.go 59.82% <100.00%> (ø)
core/eth2signeddata.go 80.95% <100.00%> (+23.40%) ⬆️
core/fetcher/fetcher.go 68.38% <100.00%> (ø)
core/parsigdb/memory.go 53.90% <100.00%> (ø)
core/proto.go 63.29% <100.00%> (-0.96%) ⬇️
core/tracker/tracker.go 79.51% <100.00%> (ø)
core/types.go 27.07% <ø> (ø)
dkg/dkg.go 57.12% <100.00%> (ø)
core/sigagg/sigagg.go 62.02% <60.00%> (-1.71%) ⬇️
core/signeddata.go 47.83% <73.46%> (+7.50%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the hell sonarlint failing 😂

Copy link

sonarcloud bot commented Nov 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.2% 13.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Collaborator

@gsora gsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

also we should have a synchronous session to review sonarcloud's rules

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 8, 2023
@obol-bulldozer obol-bulldozer bot merged commit 2593530 into main Nov 8, 2023
14 of 15 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/revert-core-interfaces branch November 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants