obolapi: update publish lock timeout to 30s #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeHackett12
approved these changes
Nov 8, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
- Coverage 53.32% 53.24% -0.08%
==========================================
Files 201 201
Lines 27574 27574
==========================================
- Hits 14703 14681 -22
- Misses 11054 11078 +24
+ Partials 1817 1815 -2
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
xenowits
added
the
merge when ready
dB2510
pushed a commit
that referenced
this pull request
Nov 8, 2023
Update timeout to 30s for publishing lock to obol-api. This ensures that DKG doesn't error if lock files are large enough (>200kb) whose publishing takes more than 5s. 30s is an empirical timeout value which is safe for publishing large lock files (1.5MB) to obol-api. category: refactor ticket: none
xenowits
added a commit
that referenced
this pull request
Nov 9, 2023
Update timeout to 30s for publishing lock to obol-api. This ensures that DKG doesn't error if lock files are large enough (>200kb) whose publishing takes more than 5s. 30s is an empirical timeout value which is safe for publishing large lock files (1.5MB) to obol-api. category: refactor ticket: none
xenowits
added a commit
that referenced
this pull request
Nov 9, 2023
Update timeout to 30s for publishing lock to obol-api. This ensures that DKG doesn't error if lock files are large enough (>200kb) whose publishing takes more than 5s. 30s is an empirical timeout value which is safe for publishing large lock files (1.5MB) to obol-api. category: refactor ticket: none
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update timeout to 30s for publishing lock to obol-api. This ensures that DKG doesn't error if lock files are large enough (>200kb) whose publishing takes more than 5s.
30s is an empirical timeout value which is safe for publishing large lock files (1.5MB) to obol-api.
category: refactor
ticket: none