core/aggsigdb: integrate into simnet #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
changed the title
corverroos
approved these changes
Mar 23, 2022
app/app.go
Outdated
| @@ -315,6 +315,7 @@ func wireSimNetCoreWorkflow(life *lifecycle.Manager, conf Config, manifest Manif | |||
|
|
|||
| life.RegisterStart(lifecycle.AsyncAppCtx, lifecycle.StartLeaderCast, lifecycle.HookFunc(consensus.Run)) | |||
| life.RegisterStart(lifecycle.AsyncBackground, lifecycle.StartScheduler, lifecycle.HookFuncErr(sched.Run)) | |||
| life.RegisterStart(lifecycle.AsyncAppCtx, lifecycle.StartScheduler, lifecycle.HookFuncCtx(aggSigDB.Run)) | |||
There was a problem hiding this comment.
you need to add a lifecycle.AggSigDB enum that is ordered correctly, can start this first, so before StartMonitoringAPI
There was a problem hiding this comment.
Do you mean I need to add a lifecycle enum before StartMonitoringAPI, so this is not the first one anymore? And then add the use of that enum to the lifecycle manager?
Wouldn't be better to have a dependecy graph of services started by the lifecycle manager, I have implemented that before
There was a problem hiding this comment.
Why is func (i OrderStart) String() so optimized?
There was a problem hiding this comment.
ahh, ok, it is autogenerated, I see
|
@corverroos Please, check, I think I did what you wanted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate AggSigDB memory implementation into dependency injection and lifecycle launching
category: feature
ticket: #220